linux-kernel - Re: [PATCH v4 1/1] scsi: pm: Balance pm_only counter of request queue during system resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu,  7 May 2020 21:16:43 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     bjorn.andersson@...aro.org, bvanassche@....org,
        kernel-team@...roid.com, nguyenb@...eaurora.org,
        alim.akhtar@...sung.com, stanley.chu@...iatek.com,
        Avri.Altman@....com, Can Guo <cang@...eaurora.org>,
        linux-scsi@...r.kernel.org, salyzyn@...gle.com,
        hongwus@...eaurora.org, rnayak@...eaurora.org,
        saravanak@...gle.com, asutoshd@...eaurora.org, beanhuo@...ron.com
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/1] scsi: pm: Balance pm_only counter of request queue during system resume

On Tue, 5 May 2020 21:55:35 -0700, Can Guo wrote:

> During system resume, scsi_resume_device() decreases a request queue's
> pm_only counter if the scsi device was quiesced before. But after that,
> if the scsi device's RPM status is RPM_SUSPENDED, the pm_only counter is
> still held (non-zero). Current scsi resume hook only sets the RPM status
> of the scsi device and its request queue to RPM_ACTIVE, but leaves the
> pm_only counter unchanged. This may make the request queue's pm_only
> counter remain non-zero after resume hook returns, hence those who are
> waiting on the mq_freeze_wq would never be woken up. Fix this by calling
> blk_post_runtime_resume() if a sdev's RPM status was RPM_SUSPENDED.
> 
> [...]

Applied to 5.7/scsi-queue, thanks!

[1/1] scsi: pm: Balance pm_only counter of request queue during system resume
      https://git.kernel.org/mkp/scsi/c/a3b923842626

-- 
Martin K. Petersen	Oracle Linux Engineering