linux-kernel - RE: [PATCH v8 0/8] scsi: ufs: support LU Dedicated buffer mode for WriteBooster

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SN6PR04MB464039C499F73656FA92014CFCA20@SN6PR04MB4640.namprd04.prod.outlook.com>
Date:   Fri, 8 May 2020 08:40:00 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Stanley Chu <stanley.chu@...iatek.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "alim.akhtar@...sung.com" <alim.akhtar@...sung.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>
CC:     "beanhuo@...ron.com" <beanhuo@...ron.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "bvanassche@....org" <bvanassche@....org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kuohong.wang@...iatek.com" <kuohong.wang@...iatek.com>,
        "peter.wang@...iatek.com" <peter.wang@...iatek.com>,
        "chun-hung.wu@...iatek.com" <chun-hung.wu@...iatek.com>,
        "andy.teng@...iatek.com" <andy.teng@...iatek.com>
Subject: RE: [PATCH v8 0/8] scsi: ufs: support LU Dedicated buffer mode for
 WriteBooster

This series looks good to me.
Thanks,
Avri

> 
> 
> Hi,
> This patchset adds LU dedicated buffer mode support for WriteBooster.
> In the meanwhile, enable WriteBooster capability on MediaTek UFS
> platforms.
> 
> v7 -> v8:
>   - In exported funtion ufshcd_fixup_dev_quirks(), add null checking for
> parameter "fixups" (Avri Altman)
> 
> v6 -> v7:
>   - Add device descriptor length check in ufshcd_wb_probe() back to prevent
> out-of-boundary access in ufshcd_wb_probe()
>   - Fix the check of device descriptor length (Avri Altman)
>   - Provide a new ufs_fixup_device_setup() function to pack both device fixup
> methods by general quirk table and vendor-specific way (Avri Altman)
> 
> v5 -> v6:
>   - Remove device descriptor length check in ufshcd_wb_probe()
> 
> v4 -> v5:
>   - Check LUN ID for available WriteBooster buffer only from 0 to 7 according
> to spec (Avri Altman)
>   - Skip checking any possible errors from ufshcd_read_unit_desc_param(hba,
> lun, UNIT_DESC_PARAM_WB_BUF_ALLOC_UNITS) in ufshcd_wb_probe() and
> check returned d_lu_wb_buf_alloc (shall be zero if error happens) (Avri
> Altman)
> 
> v3 -> v4:
>   - Introduce "fixup_dev_quirks" vops to allow vendors to fix and modify
> device quirks, and provide an initial vendor-specific device quirk table on
> MediaTek UFS platforms
>   - Avoid relying on common device quirk table for pre-3.1 UFS device with
> non-standard WriteBooster support (Can Guo)
>   - Fix comments for ufshcd_wb_probe() (Can Guo)
>   - Make ufshcd_wb_get_flag_index() inline and fix ufshcd_is_wb_flags() (Avri
> Altman)
> 
> v2 -> v3:
>   - Introduce a device quirk to support WriteBooster in pre-3.1 UFS devices
> (Avri Altman)
>   - Fix WriteBooster related sysfs nodes. Now all WriteBooster related sysfs
> nodes are specifically mapped to the LUN with WriteBooster enabled in LU
> Dedicated buffer mode (Avri Altman)
> 
> v1 -> v2:
>   - Change the definition name of WriteBooster buffer mode to correspond
> to specification (Bean Huo)
>   - Add patch #5: "scsi: ufs: cleanup WriteBooster feature"
> 
> Stanley Chu (8):
>   scsi: ufs: enable WriteBooster on some pre-3.1 UFS devices
>   scsi: ufs: introduce fixup_dev_quirks vops
>   scsi: ufs: export ufs_fixup_device_setup() function
>   scsi: ufs-mediatek: add fixup_dev_quirks vops
>   scsi: ufs: add "index" in parameter list of ufshcd_query_flag()
>   scsi: ufs: add LU Dedicated buffer mode support for WriteBooster
>   scsi: ufs-mediatek: enable WriteBooster capability
>   scsi: ufs: cleanup WriteBooster feature
> 
>  drivers/scsi/ufs/ufs-mediatek.c |  25 ++++-
>  drivers/scsi/ufs/ufs-sysfs.c    |  11 ++-
>  drivers/scsi/ufs/ufs.h          |  10 ++
>  drivers/scsi/ufs/ufs_quirks.h   |   7 ++
>  drivers/scsi/ufs/ufshcd.c       | 166 +++++++++++++++++++++-----------
>  drivers/scsi/ufs/ufshcd.h       |  19 +++-
>  6 files changed, 176 insertions(+), 62 deletions(-)
> 
> --
> 2.18.0