linux-kernel - Re: [patch V4 part 1 24/36] lockdep: Prepare for noinstr sections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200508084426.GR5298@hirez.programming.kicks-ass.net>
Date:   Fri, 8 May 2020 10:44:26 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        "Paul E. McKenney" <paulmck@...nel.org>,
        Andy Lutomirski <luto@...nel.org>,
        Alexandre Chartre <alexandre.chartre@...cle.com>,
        Frederic Weisbecker <frederic@...nel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Petr Mladek <pmladek@...e.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Juergen Gross <jgross@...e.com>,
        Brian Gerst <brgerst@...il.com>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Will Deacon <will@...nel.org>
Subject: Re: [patch V4 part 1 24/36] lockdep: Prepare for noinstr sections

On Thu, May 07, 2020 at 08:23:39PM -0400, Steven Rostedt wrote:

> > +void lockdep_hardirqs_on_prepare(unsigned long ip)

> > +void noinstr lockdep_hardirqs_on(unsigned long ip)

> Would be nice to have some kerneldoc explaining the difference between
> lockdep_hardirqs_on_prepare() and lockdep_hardirqs_on().

As the naming suggests, it's not a matter of difference, but of order,
first you call on_prepare(), then you call on(). The function signature
as per the above gives clue why.