linux-kernel - Re: [RESENT PATCH RFC v3 4/5] scsi: ufs: add unit and geometry parameters for HPB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <464f674a9a439bbfd563b5360e3a8fbbf6c41de1.camel@gmail.com>
Date:   Fri, 08 May 2020 12:15:33 +0200
From:   Bean Huo <huobean@...il.com>
To:     Bart Van Assche <bvanassche@....org>, alim.akhtar@...sung.com,
        avri.altman@....com, asutoshd@...eaurora.org, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, stanley.chu@...iatek.com,
        beanhuo@...ron.com, tomas.winkler@...el.com, cang@...eaurora.org,
        rdunlap@...radead.org
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        hch@...radead.org
Subject: Re: [RESENT PATCH RFC v3 4/5] scsi: ufs: add unit and geometry
 parameters for HPB

On Thu, 2020-05-07 at 18:04 -0700, Bart Van Assche wrote:
> > +     GEOMETRY_DESC_PARAM_HPB_REGION_SIZE     = 0x48,
> > +     GEOMETRY_DESC_PARAM_HPB_NUMBER_LU       = 0x49,
> > +     GEOMETRY_DESC_PARAM_HPB_SUBREGION_SIZE  = 0x4A,
> > +     GEOMETRY_DESC_PARAM_HPB_MAX_ACTIVE_REGIONS = 0x4B,
> >   };
> 
> How about adding the names from the spec as a comment above the new
> constants, e.g. as follows?
> 
>         /* wHPBPinnedRegionStartIdx */
>         UNIT_DESC_PARAM_HPB_PIN_REGION_START_OFFSET = 0x25,
> 
> Thanks,
> 
> Bart.

Bart
I will add in the next version.

thanks,

Bean