linux-kernel - Re: [PATCH v3] tools/bootconfig: fix resource leak in apply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e2c3348-f346-e3f2-9c7c-5c4135f9b38c@web.de>
Date:   Fri, 8 May 2020 13:03:12 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Yunfeng Ye <yeyunfeng@...wei.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Masami Hiramatsu <mhiramat@...nel.org>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Shiyuan Hu <hushiyuan@...wei.com>,
        Hewenliang <hewenliang4@...wei.com>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH v3] tools/bootconfig: fix resource leak in apply_xbc()

…
> +++ b/tools/bootconfig/main.c
> @@ -314,31 +314,35 @@ int apply_xbc(const char *path, const char *xbc_path)
…
> +free_data:
>  	free(data);
…

Would any software users prefer to omit the memory release for
a quicker program termination?

Can the commit message become clearer about the explanation for
the importance of the proposed change?

Regards,
Markus