linux-kernel - Re: [PATCH 2/3] dts: ppc: t4240rdb: add uie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200508115052.GL34497@piout.net>
Date:   Fri, 8 May 2020 13:50:52 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Biwen Li <biwen.li@....nxp.com>
Cc:     leoyang.li@....com, robh+dt@...nel.org, mpe@...erman.id.au,
        benh@...nel.crashing.org, a.zummo@...ertech.it,
        devicetree@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org, linux-rtc@...r.kernel.org,
        Biwen Li <biwen.li@....com>
Subject: Re: [PATCH 2/3] dts: ppc: t4240rdb: add uie_unsupported property to
 drop warning

On 08/05/2020 13:49:24+0800, Biwen Li wrote:
> From: Biwen Li <biwen.li@....com>
> 
> This adds uie_unsupported property to drop warning as follows:
>     - $ hwclock.util-linux
>       hwclock.util-linux: select() to /dev/rtc0
>       to wait for clock tick timed out
> 
> My case:
>     - RTC ds1374's INT pin is connected to VCC on T4240RDB,
>       then the RTC cannot inform cpu about the alarm interrupt
> 
> Signed-off-by: Biwen Li <biwen.li@....com>
> ---
>  arch/powerpc/boot/dts/fsl/t4240rdb.dts | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/boot/dts/fsl/t4240rdb.dts b/arch/powerpc/boot/dts/fsl/t4240rdb.dts
> index a56a705d41f7..ccdd10202e56 100644
> --- a/arch/powerpc/boot/dts/fsl/t4240rdb.dts
> +++ b/arch/powerpc/boot/dts/fsl/t4240rdb.dts
> @@ -144,7 +144,11 @@
>  			rtc@68 {
>  				compatible = "dallas,ds1374";
>  				reg = <0x68>;
> -				interrupts = <0x1 0x1 0 0>;

removing the interrupt should be enough to solve your issue

> +				// The ds1374's INT pin isn't
> +				// connected to cpu's INT pin,
> +				// so the rtc cannot synchronize
> +				// clock tick per second.
> +				uie_unsupported;
>  			};
>  		};
>  
> -- 
> 2.17.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com