linux-kernel - Re:[PATCH] drivers/video: cleanup coding style in video a bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AKEA*wCFCDjDmtJ1Hlm3L4pz.3.1588902787737.Hmail.bernard@vivo.com>
Date:   Fri, 8 May 2020 09:53:07 +0800 (GMT+08:00)
From:   Bernard <bernard@...o.com>
To:     Bernard Zhao <bernard@...o.com>
Cc:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Uma Shankar <uma.shankar@...el.com>,
        Ville Syrjälä <ville.syrjala@...ux.intel.com>,
        Shashank Sharma <shashank.sharma@...el.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re:[PATCH] drivers/video: cleanup coding style in video a bit


From: Bernard Zhao <bernard@...o.com>
Date: 2020-04-27 16:05:23
To:  Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,Uma Shankar <uma.shankar@...el.com>,"Ville Syrjälä" <ville.syrjala@...ux.intel.com>,Shashank Sharma <shashank.sharma@...el.com>,Laurent Pinchart <laurent.pinchart@...asonboard.com>,Daniel Vetter <daniel.vetter@...ll.ch>,Bernard Zhao <bernard@...o.com>,dri-devel@...ts.freedesktop.org,linux-fbdev@...r.kernel.org,linux-kernel@...r.kernel.org
Cc:  opensource.kernel@...o.com
Subject: [PATCH] drivers/video: cleanup coding style in video a bit>Eliminate the magic numbers, add vender infoframe size macro
>like other hdmi modules.
>
>Signed-off-by: Bernard Zhao <bernard@...o.com>
>---
> drivers/video/hdmi.c | 2 +-
> include/linux/hdmi.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c
>index 856a8c4e84a2..f693076f2e5f 100644
>--- a/drivers/video/hdmi.c
>+++ b/drivers/video/hdmi.c
>@@ -495,7 +495,7 @@ int hdmi_vendor_infoframe_init(struct hdmi_vendor_infoframe *frame)
> 	 * value
> 	 */
> 	frame->s3d_struct = HDMI_3D_STRUCTURE_INVALID;
>-	frame->length = 4;
>+	frame->length = HDMI_VENDOR_INFOFRAME_SIZE;
> 
> 	return 0;
> }
>diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h
>index 9613d796cfb1..ff25aeb95ee4 100644
>--- a/include/linux/hdmi.h
>+++ b/include/linux/hdmi.h
>@@ -57,6 +57,7 @@ enum hdmi_infoframe_type {
> #define HDMI_SPD_INFOFRAME_SIZE    25
> #define HDMI_AUDIO_INFOFRAME_SIZE  10
> #define HDMI_DRM_INFOFRAME_SIZE    26
>+#define HDMI_VENDOR_INFOFRAME_SIZE  4
> 
> #define HDMI_INFOFRAME_SIZE(type)	\
> 	(HDMI_INFOFRAME_HEADER_SIZE + HDMI_ ## type ## _INFOFRAME_SIZE)
>-- 
>2.26.2
>