linux-kernel - Re: [PATCH] net: tg3: tidy up loop, remove need to compute off with a multiply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACKFLi=A_43O6OqNGfiybpnJyuQJFV0MjoG-mrRHD0RbNumQnA@mail.gmail.com>
Date:   Fri, 8 May 2020 21:48:30 -0700
From:   Michael Chan <michael.chan@...adcom.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Colin Ian King <colin.king@...onical.com>,
        Siva Reddy Kallam <siva.kallam@...adcom.com>,
        Prashant Sreedharan <prashant@...adcom.com>,
        Michael Chan <mchan@...adcom.com>,
        "David S . Miller" <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>, kernel-janitors@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: tg3: tidy up loop, remove need to compute off with a multiply

On Fri, May 8, 2020 at 7:31 PM Joe Perches <joe@...ches.com> wrote:
>
> On Fri, 2020-05-08 at 18:48 -0700, Jakub Kicinski wrote:
> > On Sat, 9 May 2020 00:31:03 +0100 Colin Ian King wrote:
> > > > My preference would be for
> > > >
> > > > {
> > > >   int i;
> > > >   u32 off = 0;
> > > >
> > > >   for (i = 0; i < TG3_SD_NUM_RECS; i++) {
> > > >           tg3_ape_scratchpad_read(tp, (u32 *)ocir, off, TC3_OCIR_LEN);
> > > >
> > > >           if (ocir->signature != TG3_OCIR_SIG_MAGIC ||
> > > >               !(ocir->version_flags & TG3_OCIR_FLAG_ACTIVE))
> > > >                   memset(ocir, 0, TG3_OCIR_LEN);
> > > >
> > > >           off += TG3_OCIR_LEN;
> > > >           ocir++;
> > > >   }
> > > >
> > > OK, I'll send a V3 tomorrow.
> >
> > I already reviewed and applied v2, just waiting for builds to finish,
> > let's leave it.
>
>
> I think clarity should be preferred.

Either way is fine with me.  I'm fine with v2 since it's already applied.