lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 8 May 2020 22:08:24 -0700
From:   Kees Cook <>
To:     "Eric W. Biederman" <>
        Linus Torvalds <>,
        Oleg Nesterov <>, Jann Horn <>,
        Greg Ungerer <>,
        Rob Landley <>,
        Bernd Edlinger <>,, Al Viro <>,
        Alexey Dobriyan <>,
        Andrew Morton <>
Subject: Re: [PATCH 3/6] exec: Stop open coding mutex_lock_killable of

On Fri, May 08, 2020 at 01:45:25PM -0500, Eric W. Biederman wrote:
> Oleg modified the code that did
> "mutex_lock_interruptible(&current->cred_guard_mutex)" to return
> -ERESTARTNOINTR instead of -EINTR, so that userspace will never see a
> failure to grab the mutex.
> Slightly earlier Liam R. Howlett defined mutex_lock_killable for
> exactly the same situation but it does it a little more cleanly.
> Switch the code to mutex_lock_killable so that it is clearer what the
> code is doing.
> Ref: ad776537cc6b ("Add mutex_lock_killable")
> Ref: 793285fcafce ("cred_guard_mutex: do not return -EINTR to user-space")
> Signed-off-by: "Eric W. Biederman" <>

Reviewed-by: Kees Cook <>

Kees Cook

Powered by blists - more mailing lists