linux-kernel - Re: [PATCH] power: reset: ltc2952: remove set variable but unused value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <e40a971a-68b8-8d63-41d1-2617763fb042@web.de>
Date:   Sat, 9 May 2020 09:02:47 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Hongbo Yao <yaohongbo@...wei.com>, linux-pm@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Chen Zhou <chenzhou10@...wei.com>,
        Sebastian Reichel <sre@...nel.org>
Subject: Re: [PATCH] power: reset: ltc2952: remove set variable but unused
 value

> Fixes gcc '-Wunused-but-set-variable' warning:
> drivers/power/reset/ltc2952-poweroff.c:97:16: warning: variable
> ‘overruns’ set but not used [-Wunused-but-set-variable]

I suggest to improve also this commit message.

* Can it be helpful to replace the word “Fixes” by the text
  “An issue was pointed out by the compiler.”?

* How do you think about to add the wording “Thus delete the mentioned variable.”
  to the change description?

* The value of an assigned variable was not reused in this function implementation.
  Should this detail be better represented in the final commit subject?

* Would you like to add the tag “Fixes”?

Regards,
Markus