linux-kernel - Re: [PATCH -next] livepatch: Make klp_apply_object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b06688df-787e-4b60-6707-cf26426627d1@huawei.com>
Date:   Sat, 9 May 2020 08:38:39 +0800
From:   Samuel Zou <zou_wei@...wei.com>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
CC:     <jikos@...nel.org>, <mbenes@...e.cz>, <pmladek@...e.com>,
        <joe.lawrence@...hat.com>, <live-patching@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] livepatch: Make klp_apply_object_relocs static

Hi Josh,

Thanks for your review and reply.

Yes, I just copied and pasted the warning message, so I brought a 
question mark.

I will modify the description and add the fixes tag which introduced the 
issue, then will send the v2 soon.

On 2020/5/8 23:55, Josh Poimboeuf wrote:
> On Fri, May 08, 2020 at 10:53:41AM -0500, Josh Poimboeuf wrote:
>> On Fri, May 08, 2020 at 08:06:34PM +0800, Samuel Zou wrote:
>>> Fix the following sparse warning:
>>>
>>> kernel/livepatch/core.c:748:5: warning: symbol 'klp_apply_object_relocs'
>>> was not declared. Should it be static?
>>
>> Yes, it should :-)
>>
>> So instead of the question, the patch description should probably state
>> that it should be static because its only caller is in the file.
> 
> ... and it probably should also have a Fixes tag which references the
> commit which introduced this issue.
> 
>> With that change:
>>
>> Acked-by: Josh Poimboeuf <jpoimboe@...hat.com>
>