linux-kernel - Re: [PATCH -next] soc: fsl: dpio: remove set but not used variable 'addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bd4e87d7-3dc3-bef2-6eba-6599087604f1@huawei.com>
Date:   Sat, 9 May 2020 19:07:34 +0800
From:   Yuehaibing <yuehaibing@...wei.com>
To:     <Roy.Pledge@....com>, <leoyang.li@....com>,
        <youri.querry_1@....com>
CC:     <linux-kernel@...r.kernel.org>, <linuxppc-dev@...ts.ozlabs.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH -next] soc: fsl: dpio: remove set but not used variable
 'addr_cena'

Pls ignore this duplicate.

On 2020/5/8 22:10, YueHaibing wrote:
> drivers/soc/fsl/dpio//qbman-portal.c:650:11: warning: variable 'addr_cena' set but not used [-Wunused-but-set-variable]
>   uint64_t addr_cena;
>            ^~~~~~~~~
> 
> It is never used, so remove it.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/soc/fsl/dpio/qbman-portal.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/soc/fsl/dpio/qbman-portal.c b/drivers/soc/fsl/dpio/qbman-portal.c
> index e2e9fbb58a72..0ce859b60888 100644
> --- a/drivers/soc/fsl/dpio/qbman-portal.c
> +++ b/drivers/soc/fsl/dpio/qbman-portal.c
> @@ -647,7 +647,6 @@ int qbman_swp_enqueue_multiple_direct(struct qbman_swp *s,
>  	const uint32_t *cl = (uint32_t *)d;
>  	uint32_t eqcr_ci, eqcr_pi, half_mask, full_mask;
>  	int i, num_enqueued = 0;
> -	uint64_t addr_cena;
>  
>  	spin_lock(&s->access_spinlock);
>  	half_mask = (s->eqcr.pi_ci_mask>>1);
> @@ -700,7 +699,6 @@ int qbman_swp_enqueue_multiple_direct(struct qbman_swp *s,
>  
>  	/* Flush all the cacheline without load/store in between */
>  	eqcr_pi = s->eqcr.pi;
> -	addr_cena = (size_t)s->addr_cena;
>  	for (i = 0; i < num_enqueued; i++)
>  		eqcr_pi++;
>  	s->eqcr.pi = eqcr_pi & full_mask;
>