lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 9 May 2020 09:49:26 +0800
From:   Zhou Wang <wangzhou1@...ilicon.com>
To:     Rikard Falkeborn <rikard.falkeborn@...il.com>
CC:     <herbert@...dor.apana.org.au>, <davem@...emloft.net>,
        <linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/4] crypto: hisilicon/zip - constify struct debugfs_reg32

On 2020/5/9 6:35, Rikard Falkeborn wrote:
> hzip_dfx_regs is never changed and can be made const.
> 
> This allows the compiler to put it in the text section instead of the
> data section.
> 
> Before:
>    text    data     bss     dec     hex filename
>   15236    6160     480   21876    5574 drivers/crypto/hisilicon/zip/zip_main.o
> 
> After:
>    text    data     bss     dec     hex filename
>   15620    5776     480   21876    5574 drivers/crypto/hisilicon/zip/zip_main.o
> 
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@...il.com>

Reviewed-by: Zhou Wang <wangzhou1@...ilicon.com>

Thanks for fixing this.

> ---
>  drivers/crypto/hisilicon/zip/zip_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/hisilicon/zip/zip_main.c b/drivers/crypto/hisilicon/zip/zip_main.c
> index 37db11f96fab..6934a03d21e1 100644
> --- a/drivers/crypto/hisilicon/zip/zip_main.c
> +++ b/drivers/crypto/hisilicon/zip/zip_main.c
> @@ -165,7 +165,7 @@ static const u64 core_offsets[] = {
>  	[HZIP_DECOMP_CORE5] = 0x309000,
>  };
>  
> -static struct debugfs_reg32 hzip_dfx_regs[] = {
> +static const struct debugfs_reg32 hzip_dfx_regs[] = {
>  	{"HZIP_GET_BD_NUM                ",  0x00ull},
>  	{"HZIP_GET_RIGHT_BD              ",  0x04ull},
>  	{"HZIP_GET_ERROR_BD              ",  0x08ull},
> 

Powered by blists - more mailing lists