linux-kernel - Re: [PATCH -next v2] locking/osq_lock: annotate a data race in osq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <45D9EEEB-D887-485D-9045-417A7F2C6A1A@lca.pw>
Date:   Sat, 9 May 2020 12:53:38 -0400
From:   Qian Cai <cai@....pw>
To:     paulmck@...nel.org
Cc:     Will Deacon <will@...nel.org>, Elver Marco <elver@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...hat.com>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>
Subject: Re: [PATCH -next v2] locking/osq_lock: annotate a data race in osq_lock



> On May 9, 2020, at 12:12 PM, Paul E. McKenney <paulmck@...nel.org> wrote:
> 
> Ah, and I forgot to ask.  Why "if (data_race(prev->next == node)" instead
> of "if (data_race(prev->next) == node"?

I think the one you suggested is slightly better to point out the exact race. Do you want me to resend or you could squash it instead?