linux-kernel - Re: [PATCH 1/3] panel: simple: Fix size and bpp of BOE NV133FHM-N61

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200509200021.GA30802@ravnborg.org>
Date:   Sat, 9 May 2020 22:00:22 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     Douglas Anderson <dianders@...omium.org>
Cc:     Thierry Reding <thierry.reding@...il.com>, robdclark@...omium.org,
        linux-arm-msm@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] panel: simple: Fix size and bpp of BOE NV133FHM-N61

Hi Douglas

On Fri, May 08, 2020 at 03:59:00PM -0700, Douglas Anderson wrote:
> The BOE NV133FHM-N61 is documented in the original commit to be a
> 13.3" panel, but the size listed in our struct doesn't match.
> Specifically:
> 
>   math.sqrt(30.0 * 30.0 + 18.7 * 18.7) / 2.54 ==> 13.92
> 
> Searching around on the Internet shows that the size that was in the
> structure was the "Outline Size", not the "Display Area".  Let's fix
> it.
> 
> Also the Internet says that this panel supports 262K colors.  That's
> 6bpp, not 8bpp.
> 
> Fixes: b0c664cc80e8 ("panel: simple: Add BOE NV133FHM-N61")
> Signed-off-by: Douglas Anderson <dianders@...omium.org>

Added to drm-misc-next as I did not think this had to be updated in
mainline right now. Let me know if you expect it to land in mainline
soonish.

	Sam

> ---
> 
>  drivers/gpu/drm/panel/panel-simple.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index d6c29543e510..7219436499f1 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1189,10 +1189,10 @@ static const struct drm_display_mode boe_nv133fhm_n61_modes = {
>  static const struct panel_desc boe_nv133fhm_n61 = {
>  	.modes = &boe_nv133fhm_n61_modes,
>  	.num_modes = 1,
> -	.bpc = 8,
> +	.bpc = 6,
>  	.size = {
> -		.width = 300,
> -		.height = 187,
> +		.width = 294,
> +		.height = 165,
>  	},
>  	.delay = {
>  		.hpd_absent_delay = 200,
> -- 
> 2.26.2.645.ge9eca65c58-goog