linux-kernel - Re: [PATCH] video: fbdev: pxa168fb: make pxa168fb_init_mode() return void

Open Source and information security mailing list archives

Date:   Sat, 9 May 2020 23:11:04 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     Jason Yan <yanaijie@...wei.com>
Cc:     b.zolnierkie@...sung.com, dri-devel@...ts.freedesktop.org,
        linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video: fbdev: pxa168fb: make pxa168fb_init_mode() return
 void

Hi Jason.

On Wed, May 06, 2020 at 02:17:45PM +0800, Jason Yan wrote:
> No other functions use the return value of pxa168fb_init_mode() and the
> return value is always 0 now. Make it return void. This fixes the
> following coccicheck warning:
> 
> drivers/video/fbdev/pxa168fb.c:565:5-8: Unneeded variable: "ret". Return
> "0" on line 597
> 
> Signed-off-by: Jason Yan <yanaijie@...wei.com>
> ---
>  drivers/video/fbdev/pxa168fb.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c
> index aef8a3042590..eedfbd3572a8 100644
> --- a/drivers/video/fbdev/pxa168fb.c
> +++ b/drivers/video/fbdev/pxa168fb.c
> @@ -557,12 +557,11 @@ static const struct fb_ops pxa168fb_ops = {
>  	.fb_imageblit	= cfb_imageblit,
>  };
>  
> -static int pxa168fb_init_mode(struct fb_info *info,
> +static void pxa168fb_init_mode(struct fb_info *info,
>  			      struct pxa168fb_mach_info *mi)
I fixed indent while applying.
For patches in drivers/gpu/ please use --strict when you verify with
checkpatch so you catch similar issues yourself.

	Sam

>  {
>  	struct pxa168fb_info *fbi = info->par;
>  	struct fb_var_screeninfo *var = &info->var;
> -	int ret = 0;
>  	u32 total_w, total_h, refresh;
>  	u64 div_result;
>  	const struct fb_videomode *m;
> @@ -593,8 +592,6 @@ static int pxa168fb_init_mode(struct fb_info *info,
>  	div_result = 1000000000000ll;
>  	do_div(div_result, total_w * total_h * refresh);
>  	var->pixclock = (u32)div_result;
> -
> -	return ret;
>  }
>  
>  static int pxa168fb_probe(struct platform_device *pdev)
> -- 
> 2.21.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives