linux-kernel - Re: [PATCH -next] power: reset: ltc2952: remove set but used variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200509234201.md2veh4cxkdwoj2h@earth.universe>
Date:   Sun, 10 May 2020 01:42:01 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Hongbo Yao <yaohongbo@...wei.com>
Cc:     chenzhou10@...wei.com, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH -next] power: reset: ltc2952: remove set but used variable

Hi,

On Sat, May 09, 2020 at 06:36:11PM +0800, Hongbo Yao wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> drivers/power/reset/ltc2952-poweroff.c:97:16: warning: variable
> ‘overruns’ set but not used [-Wunused-but-set-variable]
>   unsigned long overruns;
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Hongbo Yao <yaohongbo@...wei.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/reset/ltc2952-poweroff.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/power/reset/ltc2952-poweroff.c b/drivers/power/reset/ltc2952-poweroff.c
> index e4a0cc45b3d1..318927938b05 100644
> --- a/drivers/power/reset/ltc2952-poweroff.c
> +++ b/drivers/power/reset/ltc2952-poweroff.c
> @@ -94,7 +94,6 @@ static enum hrtimer_restart ltc2952_poweroff_timer_wde(struct hrtimer *timer)
>  {
>  	ktime_t now;
>  	int state;
> -	unsigned long overruns;
>  	struct ltc2952_poweroff *data = to_ltc2952(timer, timer_wde);
>  
>  	if (data->kernel_panic)
> @@ -104,7 +103,7 @@ static enum hrtimer_restart ltc2952_poweroff_timer_wde(struct hrtimer *timer)
>  	gpiod_set_value(data->gpio_watchdog, !state);
>  
>  	now = hrtimer_cb_get_time(timer);
> -	overruns = hrtimer_forward(timer, now, data->wde_interval);
> +	hrtimer_forward(timer, now, data->wde_interval);
>  
>  	return HRTIMER_RESTART;
>  }
> -- 
> 2.20.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)