linux-kernel - Re: [PATCH v5 1/9] w1_therm: adding code comments and code reordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 10 May 2020 10:54:52 +0200
From:   Akira shimahara <akira215corp@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>, greg@...ah.com
Cc:     zbr@...emap.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/9] w1_therm: adding code comments and code
 reordering

Le samedi 09 mai 2020 à 19:26 -0700, Randy Dunlap a écrit :
> > +
> > +/*----------------------------------Structs-----------------------
> > ----------*/
> > +
> > +/**
> > + * struct w1_therm_family_converter
> > + * \brief Used to bind standard function call
> > + * to device specific function
> > + * it could be routed to NULL if device don't support feature
> > + */
> 
> 
> Hi,
> 
> 
> 
> All of the struct and function documentation comments in all patches
> in
> 
> this patch series should be using kernel-doc notation instead of the
> above
> 
> (whatever it is; I don't know what it is).
> 
> 
> 
> 
> 
> > +struct w1_therm_family_converter {
> > +     u8              broken;
> > +     u16             reserved;
> > +     struct w1_family        *f;
> > +     int             (*convert)(u8 rom[9]);
> > +     int             (*precision)(struct device *device, int val);
> > +     int             (*eeprom)(struct device *device);
> > +};
> > +
> 
> 
> thanks.
> 
> --
> 
> ~Randy

Hi,

Well noted, I will do it and re submit the serie. Thanks for your time.

Akira SHIMAHARA