linux-kernel - Re: [PATCH] mmc: sdhci-acpi: Add SDHCI_QUIRK2_BROKEN_64_BIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 10 May 2020 14:33:27 +0300
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Raul E Rangel <rrangel@...omium.org>,
        Nehal-bakulchandra Shah <Nehal-bakulchandra.Shah@....com>,
        linux-mmc@...r.kernel.org
Cc:     evgreen@...omium.org, Joerg Roedel <jroedel@...e.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Daniel Kurtz <djkurtz@...omium.org>, dianders@...omium.org,
        Ulf Hansson <ulf.hansson@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: sdhci-acpi: Add SDHCI_QUIRK2_BROKEN_64_BIT_DMA for
 AMDI0040

On 9/05/20 1:54 am, Raul E Rangel wrote:
> The AMD eMMC 5.0 controller does not support 64 bit DMA.
> 
> See the discussion here: https://marc.info/?l=linux-mmc&m=158879884514552&w=2
> 
> Fixes: 34597a3f60b1 ("mmc: sdhci-acpi: Add support for ACPI HID of AMD Controller with HS400")
> Signed-off-by: Raul E Rangel <rrangel@...omium.org>

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
> 
>  drivers/mmc/host/sdhci-acpi.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
> index faba53cf139b..d8b76cb8698a 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -605,10 +605,12 @@ static int sdhci_acpi_emmc_amd_probe_slot(struct platform_device *pdev,
>  }
>  
>  static const struct sdhci_acpi_slot sdhci_acpi_slot_amd_emmc = {
> -	.chip   = &sdhci_acpi_chip_amd,
> -	.caps   = MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
> -	.quirks = SDHCI_QUIRK_32BIT_DMA_ADDR | SDHCI_QUIRK_32BIT_DMA_SIZE |
> -			SDHCI_QUIRK_32BIT_ADMA_SIZE,
> +	.chip		= &sdhci_acpi_chip_amd,
> +	.caps		= MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
> +	.quirks		= SDHCI_QUIRK_32BIT_DMA_ADDR |
> +			  SDHCI_QUIRK_32BIT_DMA_SIZE |
> +			  SDHCI_QUIRK_32BIT_ADMA_SIZE,
> +	.quirks2	= SDHCI_QUIRK2_BROKEN_64_BIT_DMA,
>  	.probe_slot     = sdhci_acpi_emmc_amd_probe_slot,
>  };
>  
>