linux-kernel - Re: [PATCH v4 tip/core/rcu 05/38] rcu-tasks: Move Tasks RCU to its own file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 10 May 2020 08:39:45 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Lai Jiangshan <jiangshanlai@...il.com>
Cc:     rcu@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        kernel-team <kernel-team@...com>, Ingo Molnar <mingo@...nel.org>,
        dipankar@...ibm.com, Andrew Morton <akpm@...ux-foundation.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Josh Triplett <josh@...htriplett.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        David Howells <dhowells@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Frédéric Weisbecker <fweisbec@...il.com>,
        Oleg Nesterov <oleg@...hat.com>,
        Joel Fernandes <joel@...lfernandes.org>
Subject: Re: [PATCH v4 tip/core/rcu 05/38] rcu-tasks: Move Tasks RCU to its
 own file

On Sun, May 10, 2020 at 03:42:52PM +0800, Lai Jiangshan wrote:
> On Thu, Apr 16, 2020 at 2:19 AM <paulmck@...nel.org> wrote:
> >
> > From: "Paul E. McKenney" <paulmck@...nel.org>
> >
> > This code-movement-only commit is in preparation for adding an additional
> > flavor of Tasks RCU, which relies on workqueues to detect grace periods.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@...nel.org>
> > ---
> >  kernel/rcu/tasks.h  | 370 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  kernel/rcu/update.c | 366 +--------------------------------------------------
> 
> Hello Paul
> 
> Makes it kernel/rcu/tasks.c?
> 
> One of my old patch split it into a c-file, and it did work.
> Is there anything new or planed that prevents it to be a c-file?

It quite likely could be a c-file, but let's see things play out with
your suggestion of replacing Tasks RCU with a check in the scheduler
before making such a change.

							Thanx, Paul

> thanks
> Lai
> 
> >
> > +#include "tasks.h"
> > +
> >  #ifndef CONFIG_TINY_RCU
> >
> >  /*
> > --
> > 2.9.5
> >