linux-kernel - Re: sign-file: full functionality with modern LibreSSL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 10 May 2020 18:51:15 +0300
From:   Mikhail Novosyolov <m.novosyolov@...alinux.ru>
To:     keyrings@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: sign-file: full functionality with modern LibreSSL

19.03.2020 00:31, Mikhail Novosyolov пишет:
> Current pre-release version of LibreSSL has enabled CMS support,
> and now sign-file is fully functional with it.
>
> See https://github.com/libressl-portable/openbsd/commits/master
>
> To test buildability with current LibreSSL:
> ~$ git clone https://github.com/libressl-portable/portable.git
> ~$ cd portable && ./autogen.sh
> ~$ ./configure --prefix=/opt/libressl
> ~$ make
> ~# make install
> Go to the kernel source tree and:
> ~$ gcc -I/opt/libressl/include -L /opt/libressl/lib -lcrypto -Wl,-rpath,/opt/libressl/lib scripts/sign-file.c -o scripts/sign-file
>
> Fixes: f8688017 ("sign-file: fix build error in sign-file.c with libressl")
>
> Signed-off-by: Mikhail Novosyolov <m.novosyolov@...alinux.ru>

I would like to remember about this.

LibreSSL 3.1.1 has been released, and this patch (https://patchwork.kernel.org/patch/11446123/) is required to sign kernel modules using libressl.

Libressl 3.1.1 can sign them with functional parity with OpenSSL.

> ---
>  scripts/sign-file.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/sign-file.c b/scripts/sign-file.c
> index fbd34b8e8f57..fd4d7c31d1bf 100644
> --- a/scripts/sign-file.c
> +++ b/scripts/sign-file.c
> @@ -41,9 +41,10 @@
>   * signing with anything other than SHA1 - so we're stuck with that if such is
>   * the case.
>   */
> -#if defined(LIBRESSL_VERSION_NUMBER) || \
> -    OPENSSL_VERSION_NUMBER < 0x10000000L || \
> -    defined(OPENSSL_NO_CMS)
> +#if defined(OPENSSL_NO_CMS) || \
> +    ( defined(LIBRESSL_VERSION_NUMBER) \
> +    && (LIBRESSL_VERSION_NUMBER < 0x3010000fL) ) || \
> +    OPENSSL_VERSION_NUMBER < 0x10000000L
>  #define USE_PKCS7
>  #endif
>  #ifndef USE_PKCS7