linux-kernel - Re: [PATCH] lib: linear_ranges: Add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200510195059.dijv6ysac42a6nuq@earth.universe>
Date:   Sun, 10 May 2020 21:50:59 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
Cc:     mazziesaccount@...il.com, Mark Brown <broonie@...nel.org>,
        linux-pm@...r.kernel.org, brendanhiggins@...gle.com,
        linux-kernel@...r.kernel.org, lgirdwood@...il.com
Subject: Re: [PATCH] lib: linear_ranges: Add missing MODULE_LICENSE()

Hi,

On Sat, May 09, 2020 at 06:15:19PM +0300, Matti Vaittinen wrote:
> When linear_ranges is compiled as module we get warning
> about missing MODULE_LICENSE(). Fix it by adding
> MODULE_LICENSE("GPL") as is suggested by SPDX and EXPORTs.
> 
> Signed-off-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
> ---
> 
> I saw Mark applied the linear-ranges patch. So I sent this fix as
> incremental patch - but I still use the same Linus tree as a base of
> this fix - the linear-ranges file should be unchanged in regulator tree.
> If this does not apply I can clone regulator tree and create this fix on
> it.
> 
> I don't know if this is the correct way to fix this as the linear-ranges
> should be merged to power-supply tree.
> 
> I guess we can either:
> - Use this patch to fix regulator tree and create fixed tag for
>   power-supply(?)
> - Add this fix in the original series and resend whole series(?)
> - re-create the series and drop the already applied patches. Add this
>   fix as a fixup patch in new series and apply it to power-supply tree
>   after the linear-ranges from regulator is merged to power-supply.
> 
>  Please adviece me if this patch is not the way to go.
> 
> Oh, and I am really sorry for the trouble. I saw I had regulators=y
> in all of my compilations due to some pincontrol dependencies. So
> linear-ranges was not built as module in any of my test compilations :(
> 
> Thanks for testing Mark!

Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.com>

I think it makes sense to just queue this through the regulator tree.
Apart from that you should add a MAINTAINERS file entry for the
linear_ranges lib. Main user is regulators, so future patches should
probably be queued through its tree.

-- Sebastian

>  lib/linear_ranges.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/lib/linear_ranges.c b/lib/linear_ranges.c
> index d1336c75ccd7..9495ef3572b7 100644
> --- a/lib/linear_ranges.c
> +++ b/lib/linear_ranges.c
> @@ -12,6 +12,7 @@
>  #include <linux/export.h>
>  #include <linux/kernel.h>
>  #include <linux/linear_range.h>
> +#include <linux/module.h>
>  
>  /**
>   * linear_range_values_in_range - return the amount of values in a range
> @@ -239,3 +240,6 @@ int linear_range_get_selector_high(const struct linear_range *r,
>  	return 0;
>  }
>  EXPORT_SYMBOL_GPL(linear_range_get_selector_high);
> +
> +MODULE_DESCRIPTION("linear-ranges helper");
> +MODULE_LICENSE("GPL");
> -- 
> 2.21.0
> 
> 
> -- 
> Matti Vaittinen, Linux device drivers
> ROHM Semiconductors, Finland SWDC
> Kiviharjunlenkki 1E
> 90220 OULU
> FINLAND
> 
> ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
> Simon says - in Latin please.
> ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
> Thanks to Simon Glass for the translation =] 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)