lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 10 May 2020 07:30:50 +0200 From: Markus Elfring <Markus.Elfring@....de> To: Finn Thain <fthain@...egraphics.com.au>, Christophe Jaillet <christophe.jaillet@...adoo.fr>, netdev@...r.kernel.org Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org> Subject: Re: [PATCH] net/sonic: Fix some resource leaks in error handling paths > Is there a way to add a Fixes tag that would not invoke the -stable > process? And was that what you had in mind? Christophe Jaillet proposed to complete the exception handling also for this function implementation. I find that such a software correction is qualified for this tag. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=e99332e7b4cda6e60f5b5916cf9943a79dbef902#n183 Corresponding consequences can vary then according to the change management of involved developers. > I think 'undo_probe1' is both descriptive and consistent with commit > 10e3cc180e64 ("net/sonic: Fix a resource leak in an error handling path in > 'jazz_sonic_probe()'"). I can agree to this view (in principle). By the way: The referenced commit contains the tag “Fixes”. https://lore.kernel.org/patchwork/patch/1231354/ https://lore.kernel.org/lkml/20200427061803.53857-1-christophe.jaillet@wanadoo.fr/ > Your suggestion, 'free_dma' is also good. Thanks for your positive feedback. > But coming up with good alternatives is easy. But the change acceptance can occasionally become harder. > If every good alternative would be considered there would be no obvious way > to get a patch merged. I imagine that some alternatives can result in preferable solutions, can't they? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=e99332e7b4cda6e60f5b5916cf9943a79dbef902#n460 Regards, Markus
Powered by blists - more mailing lists