linux-kernel - Re: [PATCH 0/3] tools/memory-model, Documentation/litmus-test: Sort out location of litmus test and README

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200511173348.GX2869@paulmck-ThinkPad-P72>
Date:   Mon, 11 May 2020 10:33:48 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Akira Yokosawa <akiyks@...il.com>
Cc:     "Joel Fernandes (Google)" <joel@...lfernandes.org>,
        Boqun Feng <boqun.feng@...il.com>,
        linux-kernel@...r.kernel.org, vpillai@...italocean.com,
        Jonathan Corbet <corbet@....net>,
        Alan Stern <stern@...land.harvard.edu>,
        Andrea Parri <parri.andrea@...il.com>,
        Will Deacon <will@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Nicholas Piggin <npiggin@...il.com>,
        David Howells <dhowells@...hat.com>,
        Jade Alglave <j.alglave@....ac.uk>,
        Luc Maranget <luc.maranget@...ia.fr>,
        Daniel Lustig <dlustig@...dia.com>, linux-doc@...r.kernel.org
Subject: Re: [PATCH 0/3] tools/memory-model, Documentation/litmus-test: Sort
 out location of litmus test and README

On Sun, May 10, 2020 at 04:21:02PM +0900, Akira Yokosawa wrote:
> On Sat, 9 May 2020 12:43:30 +0900, Akira Yokosawa wrote:
> > Hi Joel,
> > 
> > Sorry for the late response but I've noticed some glitches.
> >  
> > On Sun, 22 Mar 2020 21:57:32 -0400, Joel Fernandes (Google) wrote:
> >> Move MP+onceassign+derefonce to the new Documentation/litmus-tests/rcu/
> >> directory.
> > 
> > MP+onceassign+derefonce.litmus is called out in
> > tools/memory-model/Documentation/recipes.txt as a representative example
> > of RCU related litmus test.
> > 
> > So I think it should be kept under tools/memory-model/litmus-tests.
> > 
> > Further RCU-related litmus tests can be added under Documentation/litmus-tests/.
> > 
> > IIUC, this change is not picked up by tip tree yet. So we have time to respin
> > the series targeting v5.9.
> > 
> >>
> >> More RCU-related litmus tests would be added here.
> >>
> >> Signed-off-by: Joel Fernandes (Google) <joel@...lfernandes.org>
> >>
> >> ---
> >> Cc: vpillai@...italocean.com
> >>
> >>  Documentation/litmus-tests/README                        | 9 +++++++++
> > 
> > Please note that later patches to add atomic litmus tests under
> > Documentation/litmus-tests/ by Boqun put README as
> > Documentation/litums-tests/atomic/README.
> > 
> > This patch's location of RCU's README as Documentation/litmus-tests/README
> > looks asymmetric to me.
> > 
> > I'm OK with either merging atomic's README with the top-level one or
> > moving RCU's README to under Documentation/litmus-tests/rcu.
> > 
> > Joel, Boqum, can you sort out the location of README?
> 
> So something like this?
> 
> Patch 1/3 is an independent typo fix in recipes.txt.
> Patch 2/3 reverts the MP+onceassign+derefonce relocation.
> Patch 3/3 merges atomic's README into the top-level one.
> 
> This is relative to -rcu's lkmm branch.
> 
> Thoughts?

Looks plausible to me, and thank you for reviewing this.

Joel, thoughts?

							Thanx, Paul

>         Thanks, Akira
> --
> Akira Yokosawa (3):
>   tools/memory-model: Fix reference to litmus test in recipes.txt
>   Revert "Documentation: LKMM: Move MP+onceassign+derefonce to new
>     litmus-tests/rcu/"
>   Documentation/litmus-tests: Merge atomic's README into top-level one
> 
>  Documentation/litmus-tests/README             | 22 ++++++++++++++++---
>  Documentation/litmus-tests/atomic/README      | 16 --------------
>  tools/memory-model/Documentation/recipes.txt  |  2 +-
>  .../MP+onceassign+derefonce.litmus            |  0
>  tools/memory-model/litmus-tests/README        |  3 +++
>  5 files changed, 23 insertions(+), 20 deletions(-)
>  delete mode 100644 Documentation/litmus-tests/atomic/README
>  rename {Documentation/litmus-tests/rcu => tools/memory-model/litmus-tests}/MP+onceassign+derefonce.litmus (100%)
> 
> -- 
> 2.17.1
> 
>