linux-kernel - Re: [PATCH 2/2] slimbus: core: Fix mismatch in of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGETcx8p95B0FpSmibSig7N=B=ZLZqyF7CNwvoht6OaJuux1Cg@mail.gmail.com>
Date:   Mon, 11 May 2020 11:15:01 -0700
From:   Saravana Kannan <saravanak@...gle.com>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] slimbus: core: Fix mismatch in of_node_get/put

On Mon, May 11, 2020 at 8:13 AM Srinivas Kandagatla
<srinivas.kandagatla@...aro.org> wrote:
>
> From: Saravana Kannan <saravanak@...gle.com>
>
> Adding missing corresponding of_node_put
>
> Fixes: 7588a511bdb4 ("slimbus: core: add support to device tree helper")
> Signed-off-by: Saravana Kannan <saravanak@...gle.com>
> [Srini: added fixes tag, removed NULL check and updated log]
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> ---
>  drivers/slimbus/core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c
> index 1f3beee74fdf..ae1e248a8fb8 100644
> --- a/drivers/slimbus/core.c
> +++ b/drivers/slimbus/core.c
> @@ -282,6 +282,7 @@ EXPORT_SYMBOL_GPL(slim_register_controller);
>  /* slim_remove_device: Remove the effect of slim_add_device() */
>  static void slim_remove_device(struct slim_device *sbdev)
>  {
> +       of_node_put(sbdev->dev.of_node);
>         device_unregister(&sbdev->dev);
>  }
>

The edits look fine to me.

-Saravana