lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 May 2020 22:12:59 +0100 From: Dmitry Safonov <dima@...sta.com> To: Mike Rapoport <rppt@...nel.org>, Andrew Morton <akpm@...ux-foundation.org> Cc: linux-kernel@...r.kernel.org, Dmitry Safonov <0x7f454c46@...il.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Ingo Molnar <mingo@...nel.org>, Jiri Slaby <jslaby@...e.com>, Petr Mladek <pmladek@...e.com>, Sergey Senozhatsky <sergey.senozhatsky@...il.com>, Steven Rostedt <rostedt@...dmis.org>, Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>, Chris Zankel <chris@...kel.net>, Max Filippov <jcmvbkbc@...il.com>, linux-xtensa@...ux-xtensa.org Subject: Re: [PATCHv3 42/50] xtensa: Add loglvl to show_trace() Hi Mike, On 5/11/20 8:45 PM, Mike Rapoport wrote: [..] >> @@ -511,7 +515,7 @@ void show_stack(struct task_struct *task, unsigned long *sp) >> print_hex_dump(KERN_INFO, " ", DUMP_PREFIX_NONE, >> STACK_DUMP_LINE_SIZE, STACK_DUMP_ENTRY_SIZE, >> sp, len, false); >> - show_trace(task, sp); >> + show_trace(task, stack, KERN_INFO); > > it should have been > > show_trace(task, sp, KERN_INFO); Thank you for noticing it! > > Andrew, can you fold the following patch as a fixup please: > > > diff --git a/arch/xtensa/kernel/traps.c b/arch/xtensa/kernel/traps.c > index f9217b6b45c8..efc3a29cde80 100644 > --- a/arch/xtensa/kernel/traps.c > +++ b/arch/xtensa/kernel/traps.c > @@ -515,7 +515,7 @@ void show_stack(struct task_struct *task, unsigned long *sp, const char *loglvl) > print_hex_dump(loglvl, " ", DUMP_PREFIX_NONE, > STACK_DUMP_LINE_SIZE, STACK_DUMP_ENTRY_SIZE, > sp, len, false); > - show_trace(task, stack, loglvl); > + show_trace(task, sp, loglvl); > } > > DEFINE_SPINLOCK(die_lock); > Thanks, Dmitry
Powered by blists - more mailing lists