[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202005111613.8C332ABC@keescook>
Date: Mon, 11 May 2020 16:14:23 -0700
From: Kees Cook <keescook@...omium.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: WeiXiong Liao <liaoweixiong@...winnertech.com>,
Anton Vorontsov <anton@...msg.org>,
Colin Cross <ccross@...roid.com>,
Tony Luck <tony.luck@...el.com>,
Jonathan Corbet <corbet@....net>,
Miquel Raynal <miquel.raynal@...tlin.com>,
Richard Weinberger <richard@....at>,
Vignesh Raghavendra <vigneshr@...com>,
Petr Mladek <pmladek@...e.com>,
Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
Steven Rostedt <rostedt@...dmis.org>,
Rob Herring <robh@...nel.org>,
Pavel Tatashin <pasha.tatashin@...een.com>,
linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-mtd@...ts.infradead.org
Subject: Re: [PATCH v7 11/18] pstore/zone,blk: Add console frontend support
On Mon, May 11, 2020 at 08:38:32AM -0700, Randy Dunlap wrote:
> On 5/10/20 1:24 PM, Kees Cook wrote:
> > diff --git a/fs/pstore/Kconfig b/fs/pstore/Kconfig
> > index f18cd126d83f..f1484f751c5e 100644
> > --- a/fs/pstore/Kconfig
> > +++ b/fs/pstore/Kconfig
> > @@ -236,3 +236,15 @@ config PSTORE_BLK_PMSG_SIZE
> >
> > NOTE that, both Kconfig and module parameters can configure
> > pstore/blk, but module parameters have priority over Kconfig.
> > +
> > +config PSTORE_BLK_CONSOLE_SIZE
> > + int "Size in Kbytes of console to store"
>
> maybe of console log to store"
>
> since my console size is not measured in Kbytes.
>
> > + depends on PSTORE_BLK
> > + depends on PSTORE_CONSOLE
> > + default 64
> > + help
> > + This just sets size of console (console_size) for pstore/blk. The
>
> console log
>
> > + size is in KB and must be a multiple of 4.
> > +
> > + NOTE that, both Kconfig and module parameters can configure
> > + pstore/blk, but module parameters have priority over Kconfig.
Good points! I've fixed this and a typo in the ftrace Kconfig help.
--
Kees Cook
Powered by blists - more mailing lists