linux-kernel - Re: linux-next: Fixes tag needs some work in the scsi-fixes tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1zhae2fjg.fsf@oracle.com>
Date:   Mon, 11 May 2020 19:54:59 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     "Martin K. Petersen" <martin.petersen@...cle.com>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Ewan D. Milne" <emilne@...hat.com>
Subject: Re: linux-next: Fixes tag needs some work in the scsi-fixes tree


Stephen,

>   Fixes: 4910b524ac9 ("scsi: qla2xxx: Add support for setting port speed")
>
> has these problem(s):
>
>   - SHA1 should be at least 12 digits long

I'm pretty good at spotting 8-digit SHAs but the 11 digits tripped me up
in this case.

I refined the SHA validation logic in my commit hook script to ensure 12
digits going forward.

Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering