linux-kernel - Re: [PATCH net] net: broadcom: Imply BROADCOM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 May 2020 09:21:51 +0200
From:   Marek Szyprowski <m.szyprowski@...sung.com>
To:     Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org
Cc:     nsaenzjulienne@...e.de, wahrenst@....net,
        "David S. Miller" <davem@...emloft.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        Tal Gilboa <talgi@...lanox.com>,
        Michael Chan <michael.chan@...adcom.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Andy Gospodarek <gospo@...adcom.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] net: broadcom: Imply BROADCOM_PHY for BCMGENET

Hi Florian,

On 09.05.2020 00:32, Florian Fainelli wrote:
> The GENET controller on the Raspberry Pi 4 (2711) is typically
> interfaced with an external Broadcom PHY via a RGMII electrical
> interface. To make sure that delays are properly configured at the PHY
> side, ensure that we get a chance to have the dedicated Broadcom PHY
> driver (CONFIG_BROADCOM_PHY) enabled for this to happen.
>
> Fixes: 402482a6a78e ("net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL when not needed")
> Reported-by: Marek Szyprowski <m.szyprowski@...sung.com>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
> David,
>
> I would like Marek to indicate whether he is okay or not with this
> change. Thanks!

It is better. It fixes the default values for ARM 32bit 
bcm2835_defconfig and ARM 64bit defconfig, so you can add:

Tested-by: Marek Szyprowski <m.szyprowski@...sung.com>

There is still an issue there. In case of ARM 64bit, when Genet driver 
is configured as a module, BROADCOM_PHY is also set to module. When I 
changed Genet to be built-in, BROADCOM_PHY stayed selected as module. 
This case doesn't work, as Genet driver is loaded much earlier than the 
rootfs/initrd/etc is available, thus broadcom phy driver is not loaded 
at all. It looks that some kind of deferred probe is missing there.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland