linux-kernel - Re: [PATCH v2] sched/debug: Fix requested task uclamp values shown in procfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <da48db5b-a2b3-1e4c-fcb9-67f5b03c33dd@arm.com>
Date:   Mon, 11 May 2020 10:45:14 +0200
From:   Dietmar Eggemann <dietmar.eggemann@....com>
To:     Pavankumar Kondeti <pkondeti@...eaurora.org>,
        linux-kernel@...r.kernel.org
Cc:     Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
        Valentin Schneider <valentin.schneider@....com>,
        Qais Yousef <qais.yousef@....com>
Subject: Re: [PATCH v2] sched/debug: Fix requested task uclamp values shown in
 procfs

On 11/05/2020 03:53, Pavankumar Kondeti wrote:
> The intention of commit 96e74ebf8d59 ("sched/debug: Add task uclamp
> values to SCHED_DEBUG procfs") was to print requested and effective
> task uclamp values. The requested values printed are read from p->uclamp,
> which holds the last effective values. Fix this by printing the values
> from p->uclamp_req.
> 
> Fixes: 96e74ebf8d59 ("sched/debug: Add task uclamp values to SCHED_DEBUG procfs")
> Tested-and-reviewed-by: Valentin Schneider <valentin.schneider@....com>
> Signed-off-by: Pavankumar Kondeti <pkondeti@...eaurora.org>
> ---
> 
> V2: Added "requested" prefix (suggested by Valentin)

Reviewed-by: Dietmar Eggemann <dietmar.eggemann@....com>

> 
>  kernel/sched/debug.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
> index a562df5..77ecebd 100644
> --- a/kernel/sched/debug.c
> +++ b/kernel/sched/debug.c
> @@ -948,8 +948,8 @@ void proc_sched_show_task(struct task_struct *p, struct pid_namespace *ns,
>  	P(se.avg.util_est.enqueued);
>  #endif
>  #ifdef CONFIG_UCLAMP_TASK
> -	__PS("uclamp.min", p->uclamp[UCLAMP_MIN].value);
> -	__PS("uclamp.max", p->uclamp[UCLAMP_MAX].value);
> +	__PS("requested uclamp.min", p->uclamp_req[UCLAMP_MIN].value);
> +	__PS("requested uclamp.max", p->uclamp_req[UCLAMP_MAX].value);
>  	__PS("effective uclamp.min", uclamp_eff_value(p, UCLAMP_MIN));
>  	__PS("effective uclamp.max", uclamp_eff_value(p, UCLAMP_MAX));
>  #endif