linux-kernel - [PATCH] media: uvcvideo: add a missing newline when printing parameter 'clock'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 11 May 2020 17:06:10 +0800
From:   Xiongfeng Wang <wangxiongfeng2@...wei.com>
To:     <laurent.pinchart@...asonboard.com>, <mchehab@...nel.org>
CC:     <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <wangxiongfeng2@...wei.com>
Subject: [PATCH] media: uvcvideo: add a missing newline when printing parameter 'clock'

When I cat module parameter 'clock' by sysfs, it displays as follows. It
is better to add a newline for easy reading.

[root@...k-202 ~]# cat /sys/module/uvcvideo/parameters/clock
CLOCK_MONOTONIC[root@...k-202 ~]#

Signed-off-by: Xiongfeng Wang <wangxiongfeng2@...wei.com>
---
 drivers/media/usb/uvc/uvc_driver.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
index 431d86e..e4d2334 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -2356,9 +2356,9 @@ static int uvc_reset_resume(struct usb_interface *intf)
 static int uvc_clock_param_get(char *buffer, const struct kernel_param *kp)
 {
 	if (uvc_clock_param == CLOCK_MONOTONIC)
-		return sprintf(buffer, "CLOCK_MONOTONIC");
+		return sprintf(buffer, "CLOCK_MONOTONIC\n");
 	else
-		return sprintf(buffer, "CLOCK_REALTIME");
+		return sprintf(buffer, "CLOCK_REALTIME\n");
 }
 
 static int uvc_clock_param_set(const char *val, const struct kernel_param *kp)
-- 
1.7.12.4