linux-kernel - Re: [PATCH] kernel/watchdog.c: convert {soft/hard}lockup boot parameters to sysctl aliases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03d35861-85c0-4a28-4845-02add0671351@suse.cz>
Date:   Mon, 11 May 2020 12:28:23 +0200
From:   Vlastimil Babka <vbabka@...e.cz>
To:     "Guilherme G. Piccoli" <gpiccoli@...onical.com>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Cc:     akpm@...ux-foundation.org, keescook@...omium.org,
        yzaikin@...gle.com, mcgrof@...nel.org, kernel@...ccoli.net
Subject: Re: [PATCH] kernel/watchdog.c: convert {soft/hard}lockup boot
 parameters to sysctl aliases

On 5/7/20 11:46 PM, Guilherme G. Piccoli wrote:
> After a recent change introduced by Vlastimil's series [0], kernel is
> able now to handle sysctl parameters on kernel command line; also, the
> series introduced a simple infrastructure to convert legacy boot
> parameters (that duplicate sysctls) into sysctl aliases.
> 
> This patch converts the watchdog parameters softlockup_panic and
> {hard,soft}lockup_all_cpu_backtrace to use the new alias infrastructure.
> It fixes the documentation too, since the alias only accepts values 0
> or 1, not the full range of integers. We also took the opportunity here
> to improve the documentation of the previously converted hung_task_panic
> (see the patch series [0]) and put the alias table in alphabetical order.
> 
> [0] lore.kernel.org/lkml/20200427180433.7029-1-vbabka@...e.cz
> 
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@...onical.com>

Ah, so I did miss some, as the Documentation file doesn't mention there is also
a sysctl for those parameters. Maybe it should?

Anyway, thanks.
Acked-by: Vlastimil Babka <vbabka@...e.cz>