linux-kernel - Re: [PATCH -next] power: supply: Make bd9995x_chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff7faf0add4155a10e3df12fceea8bda17050021.camel@fi.rohmeurope.com>
Date:   Mon, 11 May 2020 11:22:26 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     "sre@...nel.org" <sre@...nel.org>,
        "zou_wei@...wei.com" <zou_wei@...wei.com>
CC:     "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] power: supply: Make bd9995x_chip_reset static


On Mon, 2020-05-11 at 19:12 +0800, Samuel Zou wrote:
> Fix the following sparse warning:
> 
> drivers/power/supply/bd99954-charger.c:1028:6: warning: symbol
> 'bd9995x_chip_reset' was not declared.
> 
> The bd9995x_chip_reset() has only one call site within bd99954-
> charger.c
> It should be static
> 
> Fixes: 0902f8366491 ("power: supply: Support ROHM bd99954 charger")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Samuel Zou <zou_wei@...wei.com>

Reviewed-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>

> ---
>  drivers/power/supply/bd99954-charger.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/bd99954-charger.c
> b/drivers/power/supply/bd99954-charger.c
> index 3da39c7..ffd8bfa 100644
> --- a/drivers/power/supply/bd99954-charger.c
> +++ b/drivers/power/supply/bd99954-charger.c
> @@ -1025,7 +1025,7 @@ static int bd9995x_fw_probe(struct
> bd9995x_device *bd)
>  	return 0;
>  }
>  
> -void bd9995x_chip_reset(void *bd)
> +static void bd9995x_chip_reset(void *bd)
>  {
>  	__bd9995x_chip_reset(bd);
>  }