linux-kernel - RE: [PATCH] dt-bindings: reset: Convert i.MX7 reset to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM6PR0402MB3911ED577118BB1A0B12E3FFF5A10@AM6PR0402MB3911.eurprd04.prod.outlook.com>
Date:   Mon, 11 May 2020 11:29:51 +0000
From:   Anson Huang <anson.huang@....com>
To:     Aisheng Dong <aisheng.dong@....com>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH] dt-bindings: reset: Convert i.MX7 reset to json-schema



> Subject: RE: [PATCH] dt-bindings: reset: Convert i.MX7 reset to json-schema
> 
> [...]
> 
> > +
> > +maintainers:
> > +  - Anson Huang <Anson.Huang@....com>
> > +
> > +description: |
> > +  The system reset controller can be used to reset various set of
> > +  peripherals. Device nodes that need access to reset lines should
> > +  specify them as a reset phandle in their corresponding node as
> > +  specified in reset.txt.
> > +
> > +  For list of all valid reset indices see
> > +    <dt-bindings/reset/imx7-reset.h> for i.MX7,
> > +    <dt-bindings/reset/imx8mq-reset.h> for i.MX8MQ and
> > +    <dt-bindings/reset/imx8mq-reset.h> for i.MX8MM and
> > +    <dt-bindings/reset/imx8mq-reset.h> for i.MX8MN and
> 
> How about combine above three items?

Will do.

> 
> > +    <dt-bindings/reset/imx8mp-reset.h> for i.MX8MP
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +        - fsl,imx7d-src
> > +        - fsl,imx8mq-src
> > +        - fsl,imx8mm-src
> > +        - fsl,imx8mn-src
> > +        - fsl,imx8mp-src
> > +      - const: syscon
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  '#reset-cells':
> > +    const: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - '#reset-cells'
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > +    reset-controller@...90000 {
> > +        compatible = "fsl,imx7d-src", "syscon";
> > +        reg = <0x30390000 0x2000>;
> > +        interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
> > +        #reset-cells = <1>;
> > +    };
> > +
> > +...
> 
> Is this required?

It can be removed, will remove it in next version.

Anson