linux-kernel - Re: [PATCH] habanalabs: check if CoreSight is supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFCwf10ufEaTEDuyKJ+m4tdvk3n4g3dxW94LWsRqoO-zcDw0Tg@mail.gmail.com>
Date:   Mon, 11 May 2020 14:50:40 +0300
From:   Oded Gabbay <oded.gabbay@...il.com>
To:     Omer Shpigelman <oshpigelman@...ana.ai>
Cc:     "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] habanalabs: check if CoreSight is supported

On Sun, May 10, 2020 at 2:10 PM Omer Shpigelman <oshpigelman@...ana.ai> wrote:
>
> Coresight is not supported on simulator, therefore add a boolean for
> checking that (currently used by un-upstreamed code).
>
> Signed-off-by: Omer Shpigelman <oshpigelman@...ana.ai>
> ---
>  drivers/misc/habanalabs/goya/goya.c  | 1 +
>  drivers/misc/habanalabs/habanalabs.h | 2 ++
>  2 files changed, 3 insertions(+)
>
> diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c
> index b3e2354aaca2..fb2ff82e0db5 100644
> --- a/drivers/misc/habanalabs/goya/goya.c
> +++ b/drivers/misc/habanalabs/goya/goya.c
> @@ -751,6 +751,7 @@ static int goya_sw_init(struct hl_device *hdev)
>         }
>
>         spin_lock_init(&goya->hw_queues_lock);
> +       hdev->supports_coresight = true;
>
>         return 0;
>
> diff --git a/drivers/misc/habanalabs/habanalabs.h b/drivers/misc/habanalabs/habanalabs.h
> index a68df32094f1..cfb306daa8d4 100644
> --- a/drivers/misc/habanalabs/habanalabs.h
> +++ b/drivers/misc/habanalabs/habanalabs.h
> @@ -1415,6 +1415,7 @@ struct hl_device_idle_busy_ts {
>   * @cdev_sysfs_created: were char devices and sysfs nodes created.
>   * @stop_on_err: true if engines should stop on error.
>   * @supports_sync_stream: is sync stream supported.
> + * @supports_coresight: is CoreSight supported.
>   */
>  struct hl_device {
>         struct pci_dev                  *pdev;
> @@ -1498,6 +1499,7 @@ struct hl_device {
>         u8                              cdev_sysfs_created;
>         u8                              stop_on_err;
>         u8                              supports_sync_stream;
> +       u8                              supports_coresight;
>
>         /* Parameters for bring-up */
>         u8                              mmu_enable;
> --
> 2.17.1
>

This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@...il.com>