linux-kernel - Re: [PATCH] kgdb: Return true in kgdb_nmi_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200511130859.hfbxuc2y54ih4kjf@holly.lan>
Date:   Mon, 11 May 2020 14:08:59 +0100
From:   Daniel Thompson <daniel.thompson@...aro.org>
To:     Jason Yan <yanaijie@...wei.com>
Cc:     jason.wessel@...driver.com, dianders@...omium.org,
        kgdb-bugreport@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kgdb: Return true in kgdb_nmi_poll_knock()

On Thu, May 07, 2020 at 07:06:49PM +0800, Jason Yan wrote:
> Fix the following coccicheck warning:
> 
> include/linux/kgdb.h:301:54-55: WARNING: return of 0/1 in function
> 'kgdb_nmi_poll_knock' with return type bool
> 
> Signed-off-by: Jason Yan <yanaijie@...wei.com>

Applied, thanks.


> ---
>  include/linux/kgdb.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/kgdb.h b/include/linux/kgdb.h
> index b072aeb1fd78..042828aeb73d 100644
> --- a/include/linux/kgdb.h
> +++ b/include/linux/kgdb.h
> @@ -298,7 +298,7 @@ extern bool kgdb_nmi_poll_knock(void);
>  #else
>  static inline int kgdb_register_nmi_console(void) { return 0; }
>  static inline int kgdb_unregister_nmi_console(void) { return 0; }
> -static inline bool kgdb_nmi_poll_knock(void) { return 1; }
> +static inline bool kgdb_nmi_poll_knock(void) { return true; }
>  #endif
>  
>  extern int kgdb_register_io_module(struct kgdb_io *local_kgdb_io_ops);
> -- 
> 2.21.1
>