linux-kernel - Re: [PATCH v2] selftests/ftrace: Use printf for backslash included command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200511225805.ed665ee97d3cbd87a5ca9380@kernel.org>
Date:   Mon, 11 May 2020 22:58:05 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Andreas Schwab <schwab@...ux-m68k.org>
Cc:     Shuah Khan <shuah@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Tom Zanussi <tom.zanussi@...ux.intel.com>,
        Li Philip <philip.li@...el.com>,
        Liu Yiding <yidingx.liu@...el.com>,
        Xiao Yang <yangx.jy@...fujitsu.com>,
        David Laight <David.Laight@...LAB.COM>
Subject: Re: [PATCH v2] selftests/ftrace: Use printf for backslash included
 command

On Mon, 11 May 2020 15:42:10 +0200
Andreas Schwab <schwab@...ux-m68k.org> wrote:

> On Mai 11 2020, Masami Hiramatsu wrote:
> 
> > -    (! echo "$command" >> "$3" ) 2> /dev/null
> > +    (! printf "%s" "$command" >> "$3" ) 2> /dev/null
> 
> printf %s does not print a newline, you need printf '%s\n' for that.

Actually, ftrace doesn't need newline for single command.
The reason why we had used echo instead of "echo -n" here,
is just for short typing :)

Thank you,

-- 
Masami Hiramatsu <mhiramat@...nel.org>