linux-kernel - RE: [PATCH] misc: xilinx-sdfec: convert to module_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR02MB41406B5BD7A4379F73ECEB12CBA10@DM6PR02MB4140.namprd02.prod.outlook.com>
Date:   Mon, 11 May 2020 14:12:21 +0000
From:   Dragan Cvetic <draganc@...inx.com>
To:     Harshal Chaudhari <harshalchau04@...il.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     Derek Kiernan <dkiernan@...inx.com>,
        "arnd@...db.de" <arnd@...db.de>, Michal Simek <michals@...inx.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] misc: xilinx-sdfec: convert to module_platform_driver()



> -----Original Message-----
> From: Harshal Chaudhari <harshalchau04@...il.com>
> Sent: Sunday 10 May 2020 17:43
> To: gregkh@...uxfoundation.org
> Cc: Derek Kiernan <dkiernan@...inx.com>; Dragan Cvetic <draganc@...inx.com>; arnd@...db.de; Michal Simek
> <michals@...inx.com>; linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; harshalchau04@...il.com
> Subject: [PATCH] misc: xilinx-sdfec: convert to module_platform_driver()
> 
> The driver init and exit function don't do anything besides registering
> and unregistering the platform driver, so the module_platform_driver()
> macro could just be used instead of having separate functions.
> 
> Signed-off-by: Harshal Chaudhari <harshalchau04@...il.com>
> ---
>  drivers/misc/xilinx_sdfec.c | 20 +-------------------
>  1 file changed, 1 insertion(+), 19 deletions(-)
> 
> diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c
> index 71bbaa56bdb5..db16a42c66f4 100644
> --- a/drivers/misc/xilinx_sdfec.c
> +++ b/drivers/misc/xilinx_sdfec.c
> @@ -1484,25 +1484,7 @@ static struct platform_driver xsdfec_driver = {
>  	.remove =  xsdfec_remove,
>  };
> 
> -static int __init xsdfec_init(void)
> -{
> -	int err;
> -
> -	err = platform_driver_register(&xsdfec_driver);
> -	if (err < 0) {
> -		pr_err("%s Unabled to register SDFEC driver", __func__);
> -		return err;
> -	}
> -	return 0;
> -}
> -
> -static void __exit xsdfec_exit(void)
> -{
> -	platform_driver_unregister(&xsdfec_driver);
> -}
> -
> -module_init(xsdfec_init);
> -module_exit(xsdfec_exit);
> +module_platform_driver(xsdfec_driver);
> 
>  MODULE_AUTHOR("Xilinx, Inc");
>  MODULE_DESCRIPTION("Xilinx SD-FEC16 Driver");
> --
> 2.17.1

Acked-by: Dragan Cvetic <dragan.cvetic@...inx.com>

Thanks
Dragan