linux-kernel - Re: [PATCH v2] rtc: mc13xxx: fix a double-unlock issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200511142344.GR34497@piout.net>
Date:   Mon, 11 May 2020 16:23:44 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     wu000273@....edu
Cc:     a.zummo@...ertech.it, Markus.Elfring@....de,
        linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org,
        kjlu@....edu
Subject: Re: [PATCH v2] rtc: mc13xxx: fix a double-unlock issue

On 03/05/2020 13:22:35-0500, wu000273@....edu wrote:
> From: Qiushi Wu <wu000273@....edu>
> 
> In function mc13xxx_rtc_probe, the mc13xxx_unlock() is called
> before rtc_register_device(). But in the error path of
> rtc_register_device(), the mc13xxx_unlock() is called again,
> which causes a double-unlock problem. Thus add a call of the
> function “mc13xxx_lock” in an if branch for the completion
> of the exception handling.
> 
> Fixes: e4ae7023e182a ("rtc: mc13xxx: set range")
> Signed-off-by: Qiushi Wu <wu000273@....edu>
> ---
>  drivers/rtc/rtc-mc13xxx.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com