lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 10 May 2020 19:53:38 -0700 From: Ira Weiny <ira.weiny@...el.com> To: Arnd Bergmann <arnd@...db.de> Cc: VMware Graphics <linux-graphics-maintainer@...are.com>, Thomas Hellstrom <thellstrom@...are.com>, David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>, Christian König <christian.koenig@....com>, Christoph Hellwig <hch@....de>, Daniel Vetter <daniel.vetter@...ll.ch>, Andy Lutomirski <luto@...nel.org>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Borislav Petkov <bp@...en8.de>, Chris Zankel <chris@...kel.net>, Dan Williams <dan.j.williams@...el.com>, Dave Hansen <dave.hansen@...ux.intel.com>, "David S. Miller" <davem@...emloft.net>, Helge Deller <deller@....de>, "H. Peter Anvin" <hpa@...or.com>, Huang Rui <ray.huang@....com>, Ingo Molnar <mingo@...hat.com>, "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>, Max Filippov <jcmvbkbc@...il.com>, Paul Mackerras <paulus@...ba.org>, Peter Zijlstra <peterz@...radead.org>, Thomas Bogendoerfer <tsbogend@...ha.franken.de>, Thomas Gleixner <tglx@...utronix.de>, Al Viro <viro@...iv.linux.org.uk>, Andrew Morton <akpm@...ux-foundation.org>, Stephen Rothwell <sfr@...b.auug.org.au>, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] drm: vmwgfx: include linux/highmem.h On Sat, May 09, 2020 at 12:01:31AM +0200, Arnd Bergmann wrote: > In order to call kmap_atomic() etc, we need to include linux/highmem.h: > > drivers/gpu/drm/vmwgfx/vmwgfx_blit.c: In function 'vmw_bo_cpu_blit_line': > drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:377:4: error: implicit declaration of function 'kunmap_atomic'; did you mean 'in_atomic'? [-Werror=implicit-function-declaration] > 377 | kunmap_atomic(d->src_addr); > | ^~~~~~~~~~~~~ > | in_atomic > drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:391:5: error: implicit declaration of function 'kmap_atomic_prot' [-Werror=implicit-function-declaration] > 391 | kmap_atomic_prot(d->dst_pages[dst_page], > | ^~~~~~~~~~~~~~~~ > drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:390:16: warning: assignment to 'u8 *' {aka 'unsigned char *'} from 'int' makes pointer from integer without a cast [-Wint-conversion] > 390 | d->dst_addr = > | ^ > drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:403:16: warning: assignment to 'u8 *' {aka 'unsigned char *'} from 'int' makes pointer from integer without a cast [-Wint-conversion] > 403 | d->src_addr = > | ^ > > Fixes: 46385a895322 ("drm: remove drm specific kmap_atomic code") > Signed-off-by: Arnd Bergmann <arnd@...db.de> I'm curious about the config which failed... Because this compiled for me. Regardless it was stupid of me to not include this. Thanks, Reviewed-by: Ira Weiny <ira.weiny@...el.com> > --- > drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c b/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c > index 94d456a1d1a9..1629427d5734 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c > @@ -27,6 +27,7 @@ > **************************************************************************/ > > #include "vmwgfx_drv.h" > +#include <linux/highmem.h> > > /* > * Template that implements find_first_diff() for a generic > -- > 2.26.0 >
Powered by blists - more mailing lists