linux-kernel - Re: [PATCH] PCI: export and use pci_msi_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200511153215.spcqylnde6p36n6j@liuwe-devbox-debian-v2.j3c5onc20sse1dnehy4noqpfcg.zx.internal.cloudapp.net>
Date:   Mon, 11 May 2020 15:32:15 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Wei Liu <wei.liu@...nel.org>, linux-pci@...r.kernel.org,
        linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Andrew Murray <amurray@...goodpenguin.co.uk>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Allison Randal <allison@...utok.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Enrico Weigelt <info@...ux.net>
Subject: Re: [PATCH] PCI: export and use pci_msi_get_hwirq in pci-hyperv.c

On Thu, May 07, 2020 at 03:58:31PM -0500, Rob Herring wrote:
> On Wed, Apr 22, 2020 at 07:58:15PM +0000, Wei Liu wrote:
> > There is a functionally identical function in pci-hyperv.c. Drop it and
> > use pci_msi_get_hwirq instead.
> > 
> > This requires exporting pci_msi_get_hwirq and declaring it in msi.h.
> > 
> > No functional change intended.
> > 
> > Signed-off-by: Wei Liu <wei.liu@...nel.org>
> > ---
> >  arch/x86/include/asm/msi.h          | 4 ++++
> >  arch/x86/kernel/apic/msi.c          | 5 +++--
> >  drivers/pci/controller/pci-hyperv.c | 8 +-------
> >  3 files changed, 8 insertions(+), 9 deletions(-)
> 
> Would be better if done in a way to remove an x86 dependency. 

This is a good point, Rob. I will see what I can do.

Wei.

> 
> I guess this would do it:
> 
> #define pci_msi_get_hwirq NULL
> 
> when GENERIC_MSI_DOMAIN_OPS is enabled.