linux-kernel - Re: [PATCH] driver/hwmon/nct6775: Use kobj_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200511164734.GA23709@roeck-us.net>
Date:   Mon, 11 May 2020 09:47:34 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     zhouchuangao <chuangaozhou@...il.com>
Cc:     jdelvare@...e.com, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        zhouchuangao <zhouchuangao@...omi.com>
Subject: Re: [PATCH] driver/hwmon/nct6775: Use kobj_to_dev() API

On Mon, May 11, 2020 at 11:43:06AM +0800, zhouchuangao wrote:
> Use kobj_to_dev() API instead of container_of().
> 
> Signed-off-by: zhouchuangao <zhouchuangao@...omi.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/nct6775.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c
> index 7efa6bf..e7e1ddc 100644
> --- a/drivers/hwmon/nct6775.c
> +++ b/drivers/hwmon/nct6775.c
> @@ -2047,7 +2047,7 @@ store_temp_beep(struct device *dev, struct device_attribute *attr,
>  static umode_t nct6775_in_is_visible(struct kobject *kobj,
>  				     struct attribute *attr, int index)
>  {
> -	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct device *dev = kobj_to_dev(kobj);
>  	struct nct6775_data *data = dev_get_drvdata(dev);
>  	int in = index / 5;	/* voltage index */
>  
> @@ -2253,7 +2253,7 @@ store_fan_pulses(struct device *dev, struct device_attribute *attr,
>  static umode_t nct6775_fan_is_visible(struct kobject *kobj,
>  				      struct attribute *attr, int index)
>  {
> -	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct device *dev = kobj_to_dev(kobj);
>  	struct nct6775_data *data = dev_get_drvdata(dev);
>  	int fan = index / 6;	/* fan index */
>  	int nr = index % 6;	/* attribute index */
> @@ -2440,7 +2440,7 @@ store_temp_type(struct device *dev, struct device_attribute *attr,
>  static umode_t nct6775_temp_is_visible(struct kobject *kobj,
>  				       struct attribute *attr, int index)
>  {
> -	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct device *dev = kobj_to_dev(kobj);
>  	struct nct6775_data *data = dev_get_drvdata(dev);
>  	int temp = index / 10;	/* temp index */
>  	int nr = index % 10;	/* attribute index */
> @@ -3257,7 +3257,7 @@ store_auto_temp(struct device *dev, struct device_attribute *attr,
>  static umode_t nct6775_pwm_is_visible(struct kobject *kobj,
>  				      struct attribute *attr, int index)
>  {
> -	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct device *dev = kobj_to_dev(kobj);
>  	struct nct6775_data *data = dev_get_drvdata(dev);
>  	int pwm = index / 36;	/* pwm index */
>  	int nr = index % 36;	/* attribute index */
> @@ -3459,7 +3459,7 @@ static SENSOR_DEVICE_ATTR(beep_enable, S_IWUSR | S_IRUGO, show_beep,
>  static umode_t nct6775_other_is_visible(struct kobject *kobj,
>  					struct attribute *attr, int index)
>  {
> -	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct device *dev = kobj_to_dev(kobj);
>  	struct nct6775_data *data = dev_get_drvdata(dev);
>  
>  	if (index == 0 && !data->have_vid)
> -- 
> 2.7.4
>