linux-kernel - Re: [PATCH] coresight: platform: use dev_warn instead of dev_warn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 May 2020 10:58:51 -0600
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Kathiravan T <kathirav@...eaurora.org>
Cc:     suzuki.poulose@....com, mike.leach@...aro.org,
        alexander.shishkin@...ux.intel.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] coresight: platform: use dev_warn instead of
 dev_warn_once

Hi Kathiravan,

On Fri, May 08, 2020 at 03:58:41PM +0530, Kathiravan T wrote:
> When more than one coresight components uses the obsolete DT bindings,
> warning is displayed for only one component and not for the others.
> Lets warn it for all components by replacing dev_warn_once with dev_warn.
> 
> Signed-off-by: Kathiravan T <kathirav@...eaurora.org>
> ---
>  drivers/hwtracing/coresight/coresight-platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c
> index 43418a2..b7d9a02 100644
> --- a/drivers/hwtracing/coresight/coresight-platform.c
> +++ b/drivers/hwtracing/coresight/coresight-platform.c
> @@ -284,7 +284,7 @@ static int of_get_coresight_platform_data(struct device *dev,
>  	if (!parent) {
>  		legacy_binding = true;
>  		parent = node;
> -		dev_warn_once(dev, "Uses obsolete Coresight DT bindings\n");
> +		dev_warn(dev, "Uses obsolete Coresight DT bindings\n");

We made a concious decision to use dev_warn_once() rather than dev_warn().
There can be a lot of coresight devices on a platform and warning for every
device doesn't do anything more than adding noise.

If one device is using obsolete bindings the others very likely to do so as
well.  While fixing one device, checking the remaining devices should be
intuitive.

Thanks,
Mathieu 

>  	}
>  
>  	conn = pdata->conns;
> -- 
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation