linux-kernel - RE: [PATCH v8 09/10] scsi: ufs-exynos: add UFS host support for Exynos SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <036901d627b6$09da7050$1d8f50f0$@samsung.com>
Date:   Mon, 11 May 2020 22:33:00 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Randy Dunlap'" <rdunlap@...radead.org>, <robh@...nel.org>
Cc:     <devicetree@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
        <krzk@...nel.org>, <avri.altman@....com>,
        <martin.petersen@...cle.com>, <kwmad.kim@...sung.com>,
        <stanley.chu@...iatek.com>, <cang@...eaurora.org>,
        <linux-samsung-soc@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v8 09/10] scsi: ufs-exynos: add UFS host support for
 Exynos SoCs

Hi Randy

> -----Original Message-----
> From: Randy Dunlap <rdunlap@...radead.org>
> Sent: 11 May 2020 08:43
> To: Alim Akhtar <alim.akhtar@...sung.com>; robh@...nel.org
> Cc: devicetree@...r.kernel.org; linux-scsi@...r.kernel.org; krzk@...nel.org;
> avri.altman@....com; martin.petersen@...cle.com;
> kwmad.kim@...sung.com; stanley.chu@...iatek.com;
> cang@...eaurora.org; linux-samsung-soc@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v8 09/10] scsi: ufs-exynos: add UFS host support for Exynos
> SoCs
> 
> On 5/10/20 7:00 PM, Alim Akhtar wrote:
> > diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig index
> > e2005aeddc2d..cc7e29c8c24f 100644
> > --- a/drivers/scsi/ufs/Kconfig
> > +++ b/drivers/scsi/ufs/Kconfig
> > @@ -160,3 +160,15 @@ config SCSI_UFS_BSG
> >
> >  	  Select this if you need a bsg device node for your UFS controller.
> >  	  If unsure, say N.
> > +
> > +config SCSI_UFS_EXYNOS
> > +	bool "EXYNOS specific hooks to UFS controller platform driver"
> > +	depends on SCSI_UFSHCD_PLATFORM && ARCH_EXYNOS ||
> COMPILE_TEST
> 
> Since && has higher precedence than ||, I am thinking that this should be
> 
> 	depends on SCSI_UFSHCD_PLATFORM && (ARCH_EXYNOS ||
> COMPILE_TEST)
> 
Sure, I missed this, will add in next version.

> > +	select PHY_SAMSUNG_UFS
> > +	help
> > +	  This selects the EXYNOS specific additions to UFSHCD platform driver.
> > +	  UFS host on EXYNOS includes HCI and UNIPRO layer, and associates
> with
> > +	  UFS-PHY driver.
> > +
> > +	  Select this if you have UFS host controller on EXYNOS chipset.
> > +	  If unsure, say N.
> 
> 
> --
> ~Randy