linux-kernel - RE: [PATCH] iio: adc: exynos: Simplify Exynos7-specific init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <037501d627b8$56f06870$04d13950$@samsung.com>
Date:   Mon, 11 May 2020 22:49:28 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Krzysztof Kozlowski'" <krzk@...nel.org>,
        "'Jonathan Cameron'" <jic23@...nel.org>,
        "'Hartmut Knaack'" <knaack.h@....de>,
        "'Lars-Peter Clausen'" <lars@...afoo.de>,
        "'Peter Meerwald-Stadler'" <pmeerw@...erw.net>,
        "'Kukjin Kim'" <kgene@...nel.org>, <linux-iio@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-samsung-soc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] iio: adc: exynos: Simplify Exynos7-specific init

Hello Krzysztof,
Thanks for the patch.

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: 11 May 2020 14:04
> To: Jonathan Cameron <jic23@...nel.org>; Hartmut Knaack
> <knaack.h@....de>; Lars-Peter Clausen <lars@...afoo.de>; Peter Meerwald-
> Stadler <pmeerw@...erw.net>; Kukjin Kim <kgene@...nel.org>; Krzysztof
> Kozlowski <krzk@...nel.org>; linux-iio@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; linux-samsung-soc@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Cc: Alim Akhtar <alim.akhtar@...sung.com>
> Subject: [PATCH] iio: adc: exynos: Simplify Exynos7-specific init
> 
> The Exynos7-specific code bits in ADC driver do not play with PHY:
> the field exynos_adc_data.needs_adc_phy is not set in exynos7_adc_data
> instance.  Therefore the initialization code does not have to check if it
is true.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> 
Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>
Tested on exynos7-espresso board so,
Tested-by:  Alim Akhtar <alim.akhtar@...sung.com>

> ---
> 
> Only build tested.
> ---
>  drivers/iio/adc/exynos_adc.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
index
> 22131a677445..219c8eb32d16 100644
> --- a/drivers/iio/adc/exynos_adc.c
> +++ b/drivers/iio/adc/exynos_adc.c
> @@ -449,9 +449,6 @@ static void exynos_adc_exynos7_init_hw(struct
> exynos_adc *info)  {
>  	u32 con1, con2;
> 
> -	if (info->data->needs_adc_phy)
> -		regmap_write(info->pmu_map, info->data->phy_offset, 1);
> -
>  	con1 = ADC_V2_CON1_SOFT_RESET;
>  	writel(con1, ADC_V2_CON1(info->regs));
> 
> --
> 2.17.1