linux-kernel - Re: [PATCH v2 2/7] dt-bindings: watchdog: dw-wdt: Support devices with asynch clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200512171641.vfrrqo54dii2yuur@mobilestation>
Date:   Tue, 12 May 2020 20:16:41 +0300
From:   Serge Semin <Sergey.Semin@...kalelectronics.ru>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
CC:     Serge Semin <fancer.lancer@...il.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Rob Herring <robh+dt@...nel.org>,
        Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Paul Burton <paulburton@...nel.org>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Arnd Bergmann <arnd@...db.de>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        <linux-mips@...r.kernel.org>, <linux-watchdog@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/7] dt-bindings: watchdog: dw-wdt: Support devices
 with asynch clocks

Hello Sergei

On Mon, May 11, 2020 at 11:28:00AM +0300, Sergei Shtylyov wrote:
> On 11.05.2020 11:25, Sergei Shtylyov wrote:
> 
> > > DW Watchdog IP core can be synthesised with asynchronous timer/APB
> > > clocks support (WDT_ASYNC_CLK_MODE_ENABLE == 1). In this case
> > > a separate clock signal is supposed to be used to feed watchdog timer
> > > and APB interface of the device. Lets along with the watchdog timer
> >                                         ^ verb missing? or comma?
> 
>    Oh, and probably "Let's" too. :-)
> 
> > 
> > > reference clock expect to have the optional APB3 bu interface clock
> > > sepcified in a DW WDT dt node.
> > 
> >     Specified.

Thanks for noticing this. I'll just change the sentence to: "Let's update
the DW Watchdog DT node schema so it would support the optional APB3 bus
clock specified along with the mandatory watchdog timer reference clock."

-Sergey

> > 
> > > Signed-off-by: Serge Semin <Sergey.Semin@...kalelectronics.ru>
> > > Cc: Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>
> > > Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> > > Cc: Paul Burton <paulburton@...nel.org>
> > > Cc: Ralf Baechle <ralf@...ux-mips.org>
> > > Cc: Arnd Bergmann <arnd@...db.de>
> > > Cc: Philipp Zabel <p.zabel@...gutronix.de>
> > > Cc: linux-mips@...r.kernel.org
> > [...]
> 
> MBR, Sergei