linux-kernel - [PATCH][next] pstore/zone: fix dereference of pointer before it has been null checked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 May 2020 18:19:32 +0100
From:   Colin King <colin.king@...onical.com>
To:     Kees Cook <keescook@...omium.org>,
        Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>,
        WeiXiong Liao <liaoweixiong@...winnertech.com>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH][next] pstore/zone: fix dereference of pointer before it has been null checked

From: Colin Ian King <colin.king@...onical.com>

Currently the assignment of cnt dereferences pointer 'record' before
the pointer has been null checked. Fix this by only making this
dereference after it has been null checked close to the point cnt
is to be used.

Addresses-Coverity: ("Dereference before null check")
Fixes: 637ce64e7f57 ("pstore/zone,blk: Add support for pmsg frontend")
Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 fs/pstore/zone.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/pstore/zone.c b/fs/pstore/zone.c
index c5bf3b9f644f..3cf7d6762c76 100644
--- a/fs/pstore/zone.c
+++ b/fs/pstore/zone.c
@@ -825,7 +825,7 @@ static int notrace psz_record_write(struct pstore_zone *zone,
 		struct pstore_record *record)
 {
 	size_t start, rem;
-	int cnt = record->size;
+	int cnt;
 	bool is_full_data = false;
 	char *buf = record->buf;
 
@@ -835,6 +835,7 @@ static int notrace psz_record_write(struct pstore_zone *zone,
 	if (atomic_read(&zone->buffer->datalen) >= zone->buffer_size)
 		is_full_data = true;
 
+	cnt = record->size;
 	if (unlikely(cnt > zone->buffer_size)) {
 		buf += cnt - zone->buffer_size;
 		cnt = zone->buffer_size;
-- 
2.25.1