linux-kernel - [PATCH][next] fs: remove redundant assignment to variable ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20200512182253.223249-1-colin.king@canonical.com>
Date:   Tue, 12 May 2020 19:22:53 +0100
From:   Colin King <colin.king@...onical.com>
To:     Alexander Viro <viro@...iv.linux.org.uk>,
        linux-fsdevel@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH][next] fs: remove redundant assignment to variable ret

From: Colin Ian King <colin.king@...onical.com>

The variable ret is being assigned a value that is never read and it
is being updated later with a new value. The assignment is redundant
and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 fs/super.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/super.c b/fs/super.c
index b0a511bef4a0..6674c2af26ef 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -2052,7 +2052,6 @@ SYSCALL_DEFINE5(watch_sb,
 		if (drop_s_count)
 			put_super(s);
 	} else {
-		ret = -EBADSLT;
 		down_write(&s->s_umount);
 		ret = remove_watch_from_object(s->s_watchers, wqueue,
 					       s->s_unique_id, false);
-- 
2.25.1