| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 May 2020 03:43:34 +0800
From: kbuild test robot <lkp@...el.com>
To: Bhaumik Bhatt <bbhatt@...eaurora.org>,
manivannan.sadhasivam@...aro.org
Cc: kbuild-all@...ts.01.org, linux-arm-msm@...r.kernel.org,
linux-kernel@...r.kernel.org, hemantk@...eaurora.org,
jhugo@...eaurora.org, Bhaumik Bhatt <bbhatt@...eaurora.org>
Subject: Re: [PATCH v2 4/6] bus: mhi: core: Introduce debugfs entries and
counters for MHI
Hi Bhaumik,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on next-20200512]
[cannot apply to linus/master v5.7-rc5 v5.7-rc4 v5.7-rc3 v5.7-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Bhaumik-Bhatt/Introduce-features-and-debugfs-sysfs-entries-for-MHI/20200513-014548
base: e098d7762d602be640c53565ceca342f81e55ad2
config: m68k-allyesconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
drivers/bus/mhi/core/debugfs.c: In function 'mhi_debugfs_events_show':
>> drivers/bus/mhi/core/debugfs.c:71:33: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
71 | er_ctxt->rp, er_ctxt->wp, (u64)ring->rp,
| ^
>> drivers/bus/mhi/core/debugfs.c:70:53: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 6 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=]
70 | " rp:0x%llx wp:0x%llx local rp:0x%llx db:0x%llxn",
| ~~~^
| |
| long long unsigned int
| %x
71 | er_ctxt->rp, er_ctxt->wp, (u64)ring->rp,
72 | mhi_event->db_cfg.db_val);
| ~~~~~~~~~~~~~~~~~~~~~~~~
| |
| dma_addr_t {aka unsigned int}
drivers/bus/mhi/core/debugfs.c: In function 'mhi_debugfs_channels_show':
drivers/bus/mhi/core/debugfs.c:119:7: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
119 | (u64)ring->rp, (u64)ring->wp,
| ^
drivers/bus/mhi/core/debugfs.c:119:22: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
119 | (u64)ring->rp, (u64)ring->wp,
| ^
drivers/bus/mhi/core/debugfs.c:118:59: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 5 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=]
118 | seq_printf(m, " local rp:0x%llx local wp:0x%llx db:0x%llxn",
| ~~~^
| |
| long long unsigned int
| %x
119 | (u64)ring->rp, (u64)ring->wp,
120 | mhi_chan->db_cfg.db_val);
| ~~~~~~~~~~~~~~~~~~~~~~~
| |
| dma_addr_t {aka unsigned int}
drivers/bus/mhi/core/debugfs.c: In function 'mhi_debugfs_trigger_reset':
drivers/bus/mhi/core/debugfs.c:294:2: error: implicit declaration of function 'mhi_pm_sys_err_handler'; did you mean 'mhi_pm_sys_err_worker'? [-Werror=implicit-function-declaration]
294 | mhi_pm_sys_err_handler(mhi_cntrl);
| ^~~~~~~~~~~~~~~~~~~~~~
| mhi_pm_sys_err_worker
cc1: some warnings being treated as errors
vim +71 drivers/bus/mhi/core/debugfs.c
36
37 static int mhi_debugfs_events_show(struct seq_file *m, void *d)
38 {
39 struct mhi_controller *mhi_cntrl = m->private;
40 struct mhi_event *mhi_event;
41 struct mhi_event_ctxt *er_ctxt;
42 int i;
43
44 if (!mhi_is_active(mhi_cntrl)) {
45 seq_puts(m, "Device not ready\n");
46 return -ENODEV;
47 }
48
49 er_ctxt = mhi_cntrl->mhi_ctxt->er_ctxt;
50 mhi_event = mhi_cntrl->mhi_event;
51 for (i = 0; i < mhi_cntrl->total_ev_rings;
52 i++, er_ctxt++, mhi_event++) {
53 struct mhi_ring *ring = &mhi_event->ring;
54
55 if (mhi_event->offload_ev) {
56 seq_printf(m, "Index:%d is an offload event ring\n", i);
57 continue;
58 }
59
60 seq_printf(m, "Index:%d intmod count:%lu time:%lu",
61 i, (er_ctxt->intmod & EV_CTX_INTMODC_MASK) >>
62 EV_CTX_INTMODC_SHIFT,
63 (er_ctxt->intmod & EV_CTX_INTMODT_MASK) >>
64 EV_CTX_INTMODT_SHIFT);
65
66 seq_printf(m, " base:0x%0llx len:0x%llx", er_ctxt->rbase,
67 er_ctxt->rlen);
68
69 seq_printf(m,
> 70 " rp:0x%llx wp:0x%llx local rp:0x%llx db:0x%llx\n",
> 71 er_ctxt->rp, er_ctxt->wp, (u64)ring->rp,
72 mhi_event->db_cfg.db_val);
73 }
74
75 return 0;
76 }
77
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (56987 bytes)
Powered by blists - more mailing lists