linux-kernel - Re: [PATCH v9 1/4] dt-bindings: media: i2c: Add bindings for Maxim Integrated MAX9286

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200512223329.GA23701@bogus>
Date:   Tue, 12 May 2020 17:33:29 -0500
From:   Rob Herring <robh@...nel.org>
To:     Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
Cc:     Jacopo Mondi <jacopo@...ndi.org>,
        Hans Verkuil <hverkuil@...all.nl>,
        linux-renesas-soc@...r.kernel.org, sakari.ailus@....fi,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        Niklas Söderlund 
        <niklas.soderlund@...natech.se>, linux-kernel@...r.kernel.org,
        Kieran Bingham <kieran.bingham@...asonboard.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        devicetree@...r.kernel.org, linux-media@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Jacopo Mondi <jacopo+renesas@...ndi.org>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Niklas Söderlund 
        <niklas.soderlund+renesas@...natech.se>,
        Hyun Kwon <hyunk@...inx.com>
Subject: Re: [PATCH v9 1/4] dt-bindings: media: i2c: Add bindings for Maxim
 Integrated MAX9286

On Tue, 12 May 2020 16:51:02 +0100, Kieran Bingham wrote:
> From: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
> 
> The MAX9286 deserializes video data received on up to 4 Gigabit
> Multimedia Serial Links (GMSL) and outputs them on a CSI-2 port using up
> to 4 data lanes.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@...ndi.org>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
> Reviewed-by: Rob Herring <robh@...nel.org>
> 
> ---
> 
> v7:
>  - Collect Rob's RB tag
>  - Remove redundant maxItems from remote-endpoints
>  - Fix SPDX licence tag
> 
>  .../bindings/media/i2c/maxim,max9286.yaml     | 287 ++++++++++++++++++
>  1 file changed, 287 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml: properties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'additionalProperties'
Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/media/i2c/maxim,max9286.example.dts' failed
make[1]: *** [Documentation/devicetree/bindings/media/i2c/maxim,max9286.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
Makefile:1300: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2

See https://patchwork.ozlabs.org/patch/1288573

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

Please check and re-submit.